feat(robsond): entry pipeline observability + debug endpoint#82
Closed
ldamasio wants to merge 2 commits into
Closed
feat(robsond): entry pipeline observability + debug endpoint#82ldamasio wants to merge 2 commits into
ldamasio wants to merge 2 commits into
Conversation
Structured tracing for the immediate+automatic entry flow to diagnose positions that reach Armed state but never place orders on the exchange. Changes: - Add `flow = "entry_immediate"` tag to all logs across detector, position_manager, and executor covering the full path from ARM to order placement. - Classify OHLCV errors in detector (timeout, exchange, technical_stop) for faster root-cause identification. - Log first matching market-data tick per detector to confirm data flow. - Add `GET /debug/armed-positions` read-only endpoint returning detector task presence/finished state, stored entry policy, and last market data timestamp per symbol. - Track last market data timestamp per symbol in PositionManager. - Document trace sequence and debug endpoint in AGENTS.md and CLAUDE.md. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ability - Update CHANGELOG.md with entry pipeline observability additions. - Add GET /debug/armed-positions to README API reference. - Remove duplicate detector_task_finished log (was logged twice consecutively after spawn and after HashMap insert). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Owner
Author
|
Closing without merge after value-risk review. The initial split idea was to separate:
After a stricter value-risk review, we should not proceed with that split. Findings:
Decision: Close this PR entirely. Do not split and merge #82a by inertia. Follow-up: Create a new design issue for Robson administrative observability/debug access model, aligned with:
Only if there is an active incident around immediate-entry diagnostics should we open a new tiny PR with just the minimal detector signals, without endpoint, debug state, broad lifecycle logs, docs churn or sensitive info-level logging. Closing without merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo test— all existing tests pass🤖 Generated with Claude Code