Skip to content

Urgent fix: change default number of weak collisions to zero #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

drobnyjt
Copy link
Collaborator

@drobnyjt drobnyjt commented Jun 26, 2023

Thank you for your contribution to rustBCA!

Before submitting this PR, please make sure you have:

  • Opened an issue
  • Referenced the relevant issue number(s) below
  • Provided a description of the changes below
  • Ensured all tests pass and added any necessary tests for new code

Fixes #216

Description

This quick-fix for the unusual sputtering curves observed in issue #216 when Z1>>Z2 changes the default number of weak collisions to zero.

@drobnyjt drobnyjt changed the title Changed default number of weak collisions to 0 from 3 to avoid breaki… Urgent fix: change default number of weak collisions to zero Jun 26, 2023
@drobnyjt drobnyjt merged commit a57de11 into main Jun 26, 2023
@drobnyjt drobnyjt deleted the weak_collision_emergency_fix branch June 30, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug?] unusual sputtering yield curves when Z1 >> Z2 with weak collisions enabled
1 participant