parent id null when model is saved

[lucamenozzi]

Hello there,
I updated the library at v. 4.2.5 encountering an issue.

When saving a model, the parent column is overwritten with null value.

The parent column is correctly assigned in $parentColumn property.

If I can do tests to better specify the problem, let me know.

Thank you

p.s.: rollbacking to 4.2.4, the problem disappear.

[lazychaser]

A test case would be nice

[lucamenozzi]

Hi,
I recreated the issue in this way:

• fresh laravel installation
• added your library
• simple post insertion

[migration]

Schema::create('posts', function (Blueprint $table) {
    $table->increments('id');
    $table->string('title');
    $table->string('author');
    $table->unsignedInteger('parent_id')->nullable();
    $table->unsignedInteger('_lft');
    $table->unsignedInteger('_rgt');
    $table->timestamps();
});

[test directly in route]

Route::get('/test', function() {

    // first node creation
    $post = new App\Post();
    $post->title = 'this is the title';
    $post->author = 'me';
    $post->save();
    dump('post inserted');

    //nested node creation
    $post = App\Post::findOrFail(1);
    $duplicate_post = $post->replicate();
    $post->appendNode($duplicate_post);
    dump('post appendend');

    // replication of nested node
    $post_duplicated = App\Post::findOrFail(2);
    $replicated_post = $post_duplicated->replicate();
    $replicated_post->parent_id = 1; //parent_id explicitly inserted
    $replicated_post->save();
    return 'post replicated with issue';

});

Result: if library version is 4.2.4, everything is fine; with 4.2.5, parent_id in $replicated_post is null in DB, even if value is explicitly assigned.

Also using fixTree() doesn't change the result.

[mbardelmeijer]

Have the same issues with 4.2.5 unfortunately. Breaks our application in a minor version update :(

[lazychaser]

@lucamenozzi are you using some other packages? I cannot reproduce this issue.

[lucamenozzi]

Unfortunately not, the test with issue is on a fresh laravel installation (5.4.23) , with your package at last version (4.2.5), PHP 7.1.4 on OsX (same behaviour on Ubuntu 16.04.01), MySql 5.7.18.

[flairyu]

same problem at 4.2.6 :(

[lazychaser]

Ah. The thing is about replication. Fixed in v4.2.7