fix string bugs

Author: JohnLangford

vowpalwabbit/features.h

@@ -117,7 +117,7 @@ struct features { // the core definition of a set of features.
     v_array<feature_slice> slice = v_init<feature_slice>();
     for (size_t i = 0; i < indicies.size(); i++)
       {
-        feature_slice temp = {values[i], indicies[i] & parse_mask, audit_strings(nullptr, nullptr)};
+        feature_slice temp = {values[i], indicies[i] & parse_mask, audit_strings("", "")};
         if (space_names.size() != 0)
           temp.space_name = space_names[i];
         slice.push_back(temp);

vowpalwabbit/parse_example.cc

@@ -14,14 +14,6 @@ license as described in the file LICENSE.
 
 using namespace std;
 
-char* copy(const char* base)
-{ size_t len = 0;
-  while (base[len++] != '\0');
-  char* ret = calloc_or_throw<char>(len);
-  memcpy(ret,base,len);
-  return ret;
-}
-
 template<bool audit>
 class TC_parser
 {
@@ -110,7 +102,7 @@ class TC_parser
           { v_array<char> feature_v = v_init<char>();
             push_many(feature_v, feature_name.begin, feature_name.end - feature_name.begin);
             feature_v.push_back('\0');
-            fs.space_names.push_back(audit_strings(copy(base), feature_v.begin));
+	    fs.space_names.push_back(audit_strings(base, feature_v.begin));
           }
         if ((affix_features[index] > 0) && (feature_name.end != feature_name.begin))
           {
@@ -138,7 +130,7 @@ class TC_parser
                      affix_v.push_back('=');
                      push_many(affix_v, affix_name.begin, affix_name.end - affix_name.begin);
                      affix_v.push_back('\0');
-                     affix_fs.space_names.push_back(audit_strings(copy((char*)"affix"),affix_v.begin));
+		     fs.space_names.push_back(audit_strings("affix",affix_v.begin));
                    }
                  affix >>= 4;
               }
@@ -168,7 +160,7 @@ class TC_parser
           if (index != ' ') { spelling_v.push_back(index); spelling_v.push_back('_'); }
           push_many(spelling_v, spelling_ss.begin, spelling_ss.end - spelling_ss.begin);
           spelling_v.push_back('\0');
-          spell_fs.space_names.push_back(audit_strings(copy((char*)"spelling"),spelling_v.begin));
+          spell_fs.space_names.push_back(audit_strings("spelling",spelling_v.begin));
         }
       }
       if (namespace_dictionaries[index].size() > 0)
@@ -190,7 +182,7 @@ class TC_parser
                     ss << index << '_';
                     for (char* fc=feature_name.begin; fc!=feature_name.end; ++fc) ss << *fc;
                     ss << '=' << id;
-                    dict_fs.space_names.push_back(audit_strings(copy((char*)"dictionary"), copy(ss.str().c_str())));
+                    dict_fs.space_names.push_back(audit_strings("dictionary", ss.str()));
                   }
             }
         }

vowpalwabbit/stagewise_poly.cc

@@ -633,7 +633,7 @@ base_learner *stagewise_poly_setup(vw &all)
 
   new_options(all, "Stagewise poly options")
   ("sched_exponent", po::value<float>(), "exponent controlling quantity of included features")
-  ("batch_sz", po::value<uint64_t>(), "multiplier on batch size before including more features")
+  ("batch_sz", po::value<uint32_t>(), "multiplier on batch size before including more features")
   ("batch_sz_no_doubling", "batch_sz does not double")
 #ifdef MAGIC_ARGUMENT
   ("magic_argument", po::value<float>(), "magical feature flag")

vowpalwabbit/v_array.h

@@ -79,11 +79,11 @@ template<class T> struct v_array
   void push_back(const T& new_ele)
   { if(end == end_array)
       resize(2 * (end_array-begin) + 3);
-    *(end++) = new_ele;
+    new (end++) T(new_ele);
   }
   void push_back_unchecked(const T& new_ele)
-  { *(end++) = new_ele;
-  }
+  { new (end++) T(new_ele); }
+
   size_t find_sorted(const T& ele) const //index of the smallest element >= ele, return true if element is in the array
   { size_t size = end - begin;
     size_t a = 0;