Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ components ]: Create custom Grid component #264

Open
4 tasks
Tracked by #402
nebula-aac opened this issue Nov 8, 2023 · 3 comments
Open
4 tasks
Tracked by #402

[ components ]: Create custom Grid component #264

nebula-aac opened this issue Nov 8, 2023 · 3 comments
Assignees
Labels
component/components kind/enhancement Improvement in current feature

Comments

@nebula-aac
Copy link
Contributor

nebula-aac commented Nov 8, 2023

Meshery UI has multiple Grid implementation, specifically in the Filters, Applications and Designs (might not be applicable)

Here is an example to reference from: https://github.com/meshery/meshery/blob/master/ui/components/MesheryApplications/ApplicationsGrid.js

  • Create custom Grid component that houses the common props from the Grid implemented in Meshery UI
  • Create custom component in custom directory
  • Use existing sistent-components and provide inline styles or rely on the global MUI theme provided
  • Check to make sure that the component works properly before pushing PR

Contributor Guide

@SAHU-01
Copy link

SAHU-01 commented Aug 14, 2024

@nebula-aac, @sudhanshutech is this up for grab?
May I work on this?

@sudhanshutech
Copy link
Member

@SAHU-01 its assigned to you. I am not sure though how we will incorporate this because the components in grid and table view are coming from different components so how you gonna make this thing reusable. You have some plan so its great then

@SAHU-01
Copy link

SAHU-01 commented Aug 19, 2024

Thank you @sudhanshutech for assigning this. I was going through the codebase to figure out how tables and grid have been used throughout to take note of the requirements in the common component, I currently do not have a plan in mind on this but I'll get back to you in a day with the ideas and a rough implementation, we can discuss over that and see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/components kind/enhancement Improvement in current feature
Development

No branches or pull requests

3 participants