Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperlinked each role from permissions page reference #335

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iushdoescode
Copy link
Contributor

@iushdoescode iushdoescode commented Jul 27, 2024

Notes for Reviewers

This PR fixes #320
All the roles were hyperlinked to their corresponding permissions.

Untitled.video.-.Made.with.Clipchamp.1.mp4

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Ayush Ukhalkar <ayushuk98@gmail.com>
Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 3b7627a
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/66ab7863f5c8920008c5f34e
😎 Deploy Preview https://deploy-preview-335--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ashparshp
Copy link
Contributor

@iushdoescode Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@iushdoescode iushdoescode changed the title hyperlinked each role from permissions page refrence hyperlinked each role from permissions page reference Jul 29, 2024
Signed-off-by: Ayush Ukhalkar <97335281+iushdoescode@users.noreply.github.com>
@sudhanshutech
Copy link
Member

@iushdoescode please add this to website meeting agenda here https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit and lets discuss the progress and finalize this. Please jump in 5:30pm ist

Copy link
Contributor

@dragon-slayer875 dragon-slayer875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it so that the links open in the same tab.

Also please restore the names for roles images. The current names allow us to not have to update code if we make changes to the roles.

And please also resolve the below stated issues.

@@ -120,12 +120,12 @@ For more information, see [Organization](/cloud/identity/organizations).

{{< cardpane >}}
{{% card %}}
![workspace-administrator](/cloud/security/images/workspace-roles.svg)
![workspacea-administrator-and-workspace-manager](/cloud/identity/images/workspace-administrator-and-workspace-manager.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have since then removed the workspace manager role and this change isn't needed now.

@@ -163,12 +186,12 @@ The entitlement of "workspace owner" is automatically bestowed to the creator of

{{< cardpane >}}
{{% card %}}
![team-administrators](/cloud/security/images/team-roles.svg)
![team-admins-and-manager](/cloud/identity/images/team-admins-and-team-managers.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Team Manager role has also been deleted.

For more information, see [Teams](/cloud/identity/teams).
{{< /alert >}}

## User Role
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the removal of the user role suggested by a team member?

@sudhanshutech
Copy link
Member

@iushdoescode what the progress here?

@leecalcote
Copy link
Member

@iushdoescode, checking in... it'd be great to hear an update from you on progress here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Hyperlinks from Roles page and each role description to their list of permissions in the Permissions reference
5 participants