-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyperlinked each role from permissions page reference #335
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ayush Ukhalkar <ayushuk98@gmail.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@iushdoescode Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
Signed-off-by: Ayush Ukhalkar <97335281+iushdoescode@users.noreply.github.com>
@iushdoescode please add this to website meeting agenda here https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit and lets discuss the progress and finalize this. Please jump in 5:30pm ist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it so that the links open in the same tab.
Also please restore the names for roles images. The current names allow us to not have to update code if we make changes to the roles.
And please also resolve the below stated issues.
@@ -120,12 +120,12 @@ For more information, see [Organization](/cloud/identity/organizations). | |||
|
|||
{{< cardpane >}} | |||
{{% card %}} | |||
![workspace-administrator](/cloud/security/images/workspace-roles.svg) | |||
![workspacea-administrator-and-workspace-manager](/cloud/identity/images/workspace-administrator-and-workspace-manager.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have since then removed the workspace manager role and this change isn't needed now.
@@ -163,12 +186,12 @@ The entitlement of "workspace owner" is automatically bestowed to the creator of | |||
|
|||
{{< cardpane >}} | |||
{{% card %}} | |||
![team-administrators](/cloud/security/images/team-roles.svg) | |||
![team-admins-and-manager](/cloud/identity/images/team-admins-and-team-managers.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Team Manager role has also been deleted.
For more information, see [Teams](/cloud/identity/teams). | ||
{{< /alert >}} | ||
|
||
## User Role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the removal of the user role suggested by a team member?
@iushdoescode what the progress here? |
@iushdoescode, checking in... it'd be great to hear an update from you on progress here. |
Notes for Reviewers
This PR fixes #320
All the roles were hyperlinked to their corresponding permissions.
Untitled.video.-.Made.with.Clipchamp.1.mp4
Signed commits