Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight is buggy when combined with LaTeX equations #3229

Closed
RMeli opened this issue May 19, 2020 · 4 comments
Closed

Highlight is buggy when combined with LaTeX equations #3229

RMeli opened this issue May 19, 2020 · 4 comments
Labels
bug It's a bug desktop All desktop platforms upstream There's a problem with upstream code.

Comments

@RMeli
Copy link

RMeli commented May 19, 2020

When two distant LaTeX equations contain the symbol _ (used for subscripts in LaTeX and for italic in Mrkdown), the text in between is highlighted as italic text.

The same problem also occurs within the same equation if two _ are present.

Environment

Joplin version: 1.0.201 (e65af8c)
Platform: macOS
OS specifics: 10.14.4

Steps to reproduce

Type the following in a note:

$x_i$ Lorem Ipsum $y_i$.

The text between _ will be highlighted incorrectly as italic: i$ Lorem Ipsum $y

Describe what you expected to happen

I expect _ within equations to be ignored by the highlighter.
@RMeli RMeli added the bug It's a bug label May 19, 2020
@RMeli
Copy link
Author

RMeli commented May 19, 2020 •
edited
Loading

I only see now that this is related to #3054.

@laurent22 laurent22 added desktop All desktop platforms high High priority issues labels May 19, 2020
@tessus
Copy link
Collaborator

tessus commented May 24, 2020

ajaxorg/ace#3942

@CalebJohn CalebJohn mentioned this issue May 27, 2020
Merged
@laurent22 laurent22 added upstream There's a problem with upstream code. and removed high High priority issues labels Jun 2, 2020
@CalebJohn
Copy link
Collaborator

fixed by #3703

@RMeli
Copy link
Author

RMeli commented Sep 6, 2020

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug It's a bug desktop All desktop platforms upstream There's a problem with upstream code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tessus @laurent22 @CalebJohn @RMeli