iOS icon has black border - can be polished

[duarteocarmo]

The iOS icon shows a weird black border as you can see in the following screenshot:

Environment

Joplin version: 10.0.43
Platform: iOS
OS specifics: iPhone 11 pro max on iOS 13.3.1

Steps to reproduce

Not applicable.

Describe what you expected to happen

Expect to not see black borders.

Appreciation Note

Great work guys! Keep it up!

[duarteocarmo]

I’m gonna go ahead and say it’s probably because of some icon asset having transparency.

Reference: https://stackoverflow.com/questions/26014461/black-border-on-my-ios-icon

[duarteocarmo]

Yeah, definitely has https://fotoforensics.com/analysis.php?id=2633261c933e7934408991413711802323184780.11938&show=ela

[duarteocarmo]

Would love to pull request if someone can confirm issue!

[vernvandamn]

I don’t know if you're looking for confirmation from another user but I do see the same issue on my phone.

[duarteocarmo]

@laurent22 should I upload new icons?

[amandamcg]

I noticed this also plus on Mac I also noticed that the app icon is larger than normal and doesn't have all the sizes in the .icns file.

If someone can point me to the original icon file, I can provide the assets in all the various sizes.

[amandamcg]

In digging in further, I was able to find the icons in the assets folder. I am not able to build / test the iOS and Mac apps, so I don't feel confident creating a pull request, but I used the same naming convention that was already in use to create the following:

iOS icons

• Changed to be square instead of roundrect, which was getting cut off
• I also noticed that "29x3.png" is currently 96px x 96px. My version resizes it to 87px since I think the other was an oversight.
  Example:
  

Mac icons

• Changed to add a little bit of transparent margin and use a tighter corner radius, modeled off of the Finder icon
  Example:
  

Zip of icons

MacAndiOSIcons.zip

---

Hope this is helpful, I'm a very happy recent Joplin convert. Thanks for the hard work!

[duarteocarmo]

@amandamcg nice find, thanks for the update. Same here, also not able to build source.

The maintainer has marked this as high priority so it hopefully should be solved soon!

[duarteocarmo]

Issue follow up

Icons are still not completely there in mainly two places.

iOS

• Still shows black borders
• iPhone 11 pro max
• Running 13.3.1
• Joplin Version 10.0.46
• Database v28

Example Screenshot:

MacOS

Icon is large compared to other icons.

• MacOS version: Catalina 10.15.3
• Joplin Version: 1.0.197 (prod, darwin)
  Example Screenshot: