Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom controls to desktop application menu #2162

Closed
eschafer opened this issue Dec 8, 2019 · 3 comments
Closed

Add zoom controls to desktop application menu #2162

eschafer opened this issue Dec 8, 2019 · 3 comments
Labels
enhancement Feature requests and code enhancements

Comments

@eschafer
Copy link

eschafer commented Dec 8, 2019

Most apps let you globally zoom in, zoom out, and reset back to 100% through the application menu (and with keyboard shortcuts). I know there's the global zoom percentage setting, but that changes font sizes rather than scaling the whole page uniformly.

Here's what it currently looks like with the global zoom percentage set to 200:
Screen Shot 2019-12-08 at 1 02 19 AM

And here's what it would look like zoomed in at 200%, using Electron's webFrame.setZoomFactor():
Screen Shot 2019-12-08 at 1 02 21 AM

I already have this running locally - let me know if you're interested in a PR!

@eschafer eschafer added the bug It's a bug label Dec 8, 2019
@laurent22
Copy link
Owner

Thanks for the info and the second version indeed looks much better. Is there any drawback using this method, did you notice any bug or something not working properly? If not then yes I'd accept a pull request with this change.

@laurent22 laurent22 added enhancement Feature requests and code enhancements and removed bug It's a bug labels Dec 8, 2019
@eschafer
Copy link
Author

eschafer commented Dec 8, 2019

I don't think there are any drawbacks, and it wouldn't be changing any existing functionality. There are still some edge cases where if you zoom in far enough and have enough panels open you won't be able to see everything, but I figured that was out of scope based on how much extra work that would take.

@tessus
Copy link
Collaborator

tessus commented Dec 9, 2019

There are still some edge cases where if you zoom in far enough and have enough panels open you won't be able to see everything

I think we can ignore this edge case. That's the same thing has holding a sheet of paper 5 cm away from your eyes. ;-)

@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Feature requests and code enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants