Fix start() re-entrancy (#1) #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix start() re-entrancy * Add re-entrancy unit test
|
Hi there @g-mark , thank you for the contribution! I have it on my list to take a look at the changes and related code/behavior and if it looks good, we'll integrate the change. |
keelerm84
approved these changes
May 30, 2023
keelerm84
added a commit
that referenced
this pull request
Jun 5, 2023
## [3.1.0] - 2023-06-05 ### Changed: - Enforce TLS v1.2 as a required minimum. ### Fixed: - Fix re-entrancy issue with `start` command. (Thanks, [g-mark](#56)!)
keelerm84
added a commit
that referenced
this pull request
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an
EventSource.start()re-entrancy problemWhen:
EventSource.start()is calledEventSource.start()is called again, before the network response from the first call has been receivedThen:
URLSessionandURLRequestare created, and a newURLSessionDataTaskis startedThe underlying issue is that
start()is checking forreadyState==.raw, butreadyStateisn't set until a network response has been received.Requirements
Related issues
None
Describe the solution you've provided
Set
readyState = .connectinginstart(), immediately after checking forreadyState == .raw.Describe alternatives you've considered
None
Additional context
None