-
Notifications
You must be signed in to change notification settings - Fork 1
feat!: Drop support for Python 3.8 (eol 2024-10-07) #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release-As: 1.3.0 Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
Original prompt from mkeeler@launchdarkly.com:
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Upgrade Sphinx from ^1.3.0 to ^5.0.0 to resolve 'No module named pipes' error - Python 3.13 removed the pipes module that old Sphinx versions depend on - Verified documentation builds successfully with Sphinx 5.3.0 Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
- Upgrade from Sphinx ^5.0.0 to ^7.0.0 to resolve Python 3.13 issues - Fixes 'No module named pipes' error on Linux Python 3.13 - Fixes 'alabaster extension needs at least Sphinx v3.4' error on Windows Python 3.11 - Verified documentation build works locally with Python 3.13.0 and Sphinx 7.3.7 Co-Authored-By: mkeeler@launchdarkly.com <keelerm84@gmail.com>
keelerm84
approved these changes
Jun 26, 2025
keelerm84
pushed a commit
that referenced
this pull request
Jun 26, 2025
🤖 I have created a release *beep* *boop* --- ## [1.3.0](1.2.4...1.3.0) (2025-06-26) ### ⚠ BREAKING CHANGES * Drop support for Python 3.8 (eol 2024-10-07) ([#49](#49)) ### Features * Drop support for Python 3.8 (eol 2024-10-07) ([#49](#49)) ([a57558e](a57558e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for Python 3.8 and add Python 3.13 support across LaunchDarkly Python repositories
Summary
This PR implements a coordinated update across 6 LaunchDarkly Python repositories to drop support for Python 3.8 (EOL 2024-10-07) and add support for Python 3.13. The changes follow the pattern established in python-server-sdk commit 02076650064d8a20f792c80cda3249a7aa7e336a.
Repositories updated:
Key changes per repository:
Programming Language :: Python :: 3.8
classifierProgramming Language :: Python :: 3.13
classifierReview & Testing Checklist for Human
Risk Level: YELLOW - Moderate risk due to breaking changes and dependency upgrades
make docs
locallyRecommended test plan: Install each updated library in a fresh Python 3.13 environment and run basic import/usage tests to ensure core functionality works beyond just CI checks.
Diagram
Notes
pipes
andimghdr
modules. This was the most complex part of the migration.Link to Devin run: https://app.devin.ai/sessions/3f70248c29dd4d5eb70be4a05a78ce3a
Requested by: @keelerm84