Skip to content

urllib3 1.25 and below does not work with this library #25

Closed
@99littlebugs

Description

@99littlebugs

Describe the bug
urllib3 < 1.26.0 does not work with this library even though pyproject.toml allows urllib3 = ">=1.22.0,<3"

To reproduce

  1. Use launchdarkly-server-sdk version 9.2.0 and launchdarkly-eventsource version 1.1.0, along with urllib3 version 1.25.10
  2. When trying to evaluate flags (with streaming turned on), continually get the error Unexpected error on stream connection: __init__() got an unexpected keyword argument 'other', will retry

Expected behavior
No errors and the ability to evaluate flags.

Logs
If applicable, add any log output related to your problem.

SDK version
launchdarkly-server-sdk version 9.2.0 and launchdarkly-eventsource version 1.1.0

Language version, developer tools
Python 3.8.18

OS/platform
N/A

Additional context
Tracing the errors, we've found that this library used the urllib3 retry object here and is passing in other as an argument. urllib3 doesn't support the other keyword prior to 1.26.0 (see MR)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions