add integration tests to CircleCI build #53
Conversation
…eCI and installs apcu extension on php56. add APCU-feature-requester which is the >=php55 version of the <=php54 APC-feature-requester.
|
looks like my console output was truncated at the top there. i simply ran |
| @@ -0,0 +1,32 @@ | |||
| <?php | |||
There was a problem hiding this comment.
What's the intention for having this class vs ApcLDDFeatureRequester? Their phpdoc is the same. Adding use cases and examples to the Readme would also be great.
There was a problem hiding this comment.
APC and APCU are different extensions. please correct me if i'm wrong; APC is only available up to php54. beyond that, the docs recommend usage of the built-in op-code cache. so a compatible APCU extension was created for >=php56. my change will allow integrations to choose APC or APCU based on which extension they have installed and should cover a wider range of PHP versions. i felt i needed to do this as a part of this merge request because i'm trying to get the integration tests to run on CircleCI for the default php56 version, which does not support APC (i think). the integration tests that run in the Vagrant VM switch the PHP version to php54, which is fine, but i think we should be able to run integration tests on other php versions.
i'd be happy to update the docs with use cases and examples. didn't know if this was a welcome proposal. also, the integration tests are failing the build, for a couple of reasons. one is that monolog needs to be installed (addressed here #55) and the other (i think) is that the feature-generator function in the integration tests needs to be updated. i took a crack at it in another pull request, but i felt it was getting bloated. thoughts on how to proceed?
There was a problem hiding this comment.
I've merged #55 so that should be be ok now. Yes please update the docs regarding apc vs. apcu. Your changes are definitely welcome.
Thanks!
|
closing in favor of #58 |
make prefix concatenation in DynamoDB consistent with other SDKs
add integration tests to CircleCI build. starts redis server on CircleCI and installs apcu extension on php56. add APCU-feature-requester which is the >=php55 version of the <=php54 APC-feature-requester.
integration tests fail in CI, which is consistent with my Vagrant VM experience:
due to this provision error
-bash: /root/.phpbrew/bashrc: Permission denied, i have a feeling that my provisioner didn't get past this line:https://github.com/launchdarkly/php-client/blob/master/integration-tests/bootstrap.sh#L51
additionally, i think
\LaunchDarkly\Tests\LDDFeatureRetrieverTest::gen_featureis out-of-date. i updated the generated data in my TravisCI integration test pull request, but i'm wondering if maybe i'm just not doing something right. any ideas?