update feature-generator in integration-test #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abacaphiliac
commented
Dec 18, 2016
abacaphiliac
commented
- update feature-generator in integration-test to return json-object with all required keys and appropriate variation-structures.
- update APC integration test to verify value is baz after setting baz directly into redis (i believe this was a problem in earlier versions as well).
- add required monolog dependency to integration test composer config.
…th all required keys and appropriate variation-structures. update APC integration test to verify value is baz after setting baz directly into redis (i believe this was a problem in v1.0.0 as well).
abacaphiliac
commented
Dec 18, 2016
| @@ -40,26 +40,61 @@ public function testGetApc() { | |||
|
|
|||
| # cached value so not updated | |||
| $redis->hset("launchdarkly:features", 'foo', $this->gen_feature("foo", "baz")); | |||
| $this->assertEquals("bar", $client->variation('foo', $user, 'jim')); | |||
| $this->assertEquals("baz", $client->variation('foo', $user, 'jim')); | |||
There was a problem hiding this comment.
ok, i now know that this change is not acceptable. i'm having trouble understanding why it seems to be necessary in my vagrant test-suite. closing this merge request. i'll focus on getting the integration tests to run in CI instead.
|
closing because i know the value change from bar to baz is not acceptable. |
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Jan 3, 2020
don't let user fall outside of last bucket in rollout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.