Skip to content

Commit e440463

Browse files
authored
Merge pull request #43 from launchdarkly/drichelson/ch258/php-5-3-incompatibility
Fix PHP 5.3 incompatibilities
2 parents 110ea42 + ef206de commit e440463

File tree

11 files changed

+265
-203
lines changed

11 files changed

+265
-203
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
11
Contributing to the LaunchDarkly SDK for PHP
22
================================================
33

4-
We encourage pull-requests and other contributions from the community. We've also published an [SDK contributor's guide](http://docs.launchdarkly.com/v1.0/docs/sdk-contributors-guide) that provides a detailed explanation of how our SDKs work.
4+
We encourage pull-requests and other contributions from the community. We've also published an [SDK contributor's guide](http://docs.launchdarkly.com/v1.0/docs/sdk-contributors-guide) that provides a detailed explanation of how our SDKs work.
5+
6+
7+
This can help with getting php 5.3 on your mac: https://github.com/Homebrew/homebrew-php
8+
9+
To see composer dependency graph:
10+
`php composer.phar show -i -t`

circle.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
machine:
22
php:
3-
version: 5.4.37
3+
version: 5.3.25
44

55
test:
66
override:
7+
# syntax check php files
8+
- find ./src -name "*.php" -type f -print0 | xargs -0 -I {} php -l {}
9+
- find ./tests -name "*.php" -type f -print0 | xargs -0 -I {} php -l {}
710
- vendor/bin/phpunit tests

composer.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@
2020
}
2121
],
2222
"require": {
23-
"php": ">=5.3",
23+
"php": "~5.3",
2424
"guzzle/guzzle": "dev-master#ecb935d2d0ecd8cddae4dcfb90515cac5e2cb023",
25-
"psr/log": "1.0.0"
25+
"psr/log": "1.0.0",
26+
"justinrainbow/json-schema": "v1.6.0"
2627
},
2728
"require-dev": {
2829
"phpunit/phpunit": "4.8.26",

0 commit comments

Comments
 (0)