fix WARNING: array_map(): Argument #2 should be an array in vendor/launchdarkly/launchdarkly-php/src/LaunchDarkly/FeatureFlag.php on line 60 where FeatureFlag assumes prerequisites will always be an array. in an ld-relay test i see that prerequisites can be null so that must be handled here.

Author: abacaphiliac

src/LaunchDarkly/FeatureFlag.php

@@ -57,7 +57,7 @@ public static function getDecoder() {
                 $v['key'],
                 $v['version'],
                 $v['on'],
-                array_map(Prerequisite::getDecoder(), $v['prerequisites']),
+                array_map(Prerequisite::getDecoder(), $v['prerequisites'] ?: []),
                 $v['salt'],
                 array_map(Target::getDecoder(), $v['targets']),
                 array_map(Rule::getDecoder(), $v['rules']),

tests/FeatureFlagTest.php

@@ -140,5 +140,52 @@ public function testDecode() {
         FeatureFlag::decode(\GuzzleHttp\json_decode(FeatureFlagTest::$json1, true));
         FeatureFlag::decode(\GuzzleHttp\json_decode(FeatureFlagTest::$json2, true));
     }
+    
+    public function dataDecodeMulti()
+    {
+        return [
+            'null-prerequisites' => [
+                [
+                    'key' => 'sysops-test',
+                    'version' => 14,
+                    'on' => true,
+                    'prerequisites' => NULL,
+                    'salt' => 'c3lzb3BzLXRlc3Q=',
+                    'sel' => '8ed13de1bfb14507ba7e6dde01f3e035',
+                    'targets' => [
+                        [
+                            'values' => [],
+                            'variation' => 0,
+                        ],
+                        [
+                            'values' => [],
+                            'variation' => 1,
+                        ],
+                    ],
+                    'rules' => [],
+                    'fallthrough' => [
+                        'variation' => 0,
+                    ],
+                    'offVariation' => NULL,
+                    'variations' => [
+                        true,
+                        false,
+                    ],
+                    'deleted' => false,
+                ]
+            ],
+        ];
+    }
+    
+    /**
+     * @dataProvider dataDecodeMulti
+     * @param array $feature
+     */
+    public function testDecodeMulti(array $feature)
+    {
+        $featureFlag = FeatureFlag::decode($feature);
+        
+        self::assertInstanceOf(FeatureFlag::class, $featureFlag);
+    }
 }