Skip to content

Commit 4b0b6eb

Browse files
committed
Merge branch 'contrib' into private-main
2 parents 3dff005 + 4097d6e commit 4b0b6eb

File tree

2 files changed

+32
-1
lines changed

2 files changed

+32
-1
lines changed

src/LaunchDarkly/Integrations/TestData.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public function update(FlagBuilder $flagBuilder): TestData
110110

111111
$oldFlag = $this->_currentFlags[$key] ?? null;
112112
if ($oldFlag) {
113-
$oldVersion = $oldFlag['version'];
113+
$oldVersion = $oldFlag->getVersion();
114114
}
115115

116116
$newFlag = $flagBuilder->build($oldVersion + 1);

tests/Integrations/TestDataTest.php

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,37 @@ public function testCanSetAndGetFeatureFlag()
430430
$this->assertEquals($expectedFeatureFlag, $featureFlag);
431431
}
432432

433+
public function testCanSetAndResetFeatureFlag()
434+
{
435+
$key = 'test-flag';
436+
$expectedUpdatedFlagJson = [
437+
'key' => $key,
438+
'version' => 2,
439+
'deleted' => false,
440+
'on' => true,
441+
'targets' => [],
442+
'rules' => [],
443+
'offVariation' => 1,
444+
'fallthrough' => ['variation' => 2],
445+
'variations' => ['red', 'amber', 'green'],
446+
447+
/* Required FeatureFlag fields */
448+
'salt' => null,
449+
'prerequisites' => [],
450+
];
451+
$expectedUpdatedFeatureFlag = FeatureFlag::decode($expectedUpdatedFlagJson);
452+
453+
$td = new TestData();
454+
$flag = $td->flag($key);
455+
$td->update($flag);
456+
457+
$updatedFlag = $flag->variations('red', 'amber', 'green')->fallthroughVariation(2);
458+
$td->update($updatedFlag);
459+
460+
$featureFlag = $td->getFeature($key);
461+
$this->assertEquals($expectedUpdatedFeatureFlag, $featureFlag);
462+
}
463+
433464
public function testFlagBuilderCanAddAndBuildRules()
434465
{
435466
$td = new TestData();

0 commit comments

Comments
 (0)