Skip to content

Commit 37466e2

Browse files
authored
remove database integrations from SDK (#63)
1 parent f9138f0 commit 37466e2

24 files changed

+2
-1207
lines changed

.circleci/config.yml

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ workflows:
1414
#- test-with-preinstalled-php:
1515
# name: PHP 8.0
1616
# docker-image: cimg/php:8.1
17-
- integration-test
1817

1918
jobs:
2019
test-with-preinstalled-php:
@@ -24,9 +23,6 @@ jobs:
2423

2524
docker:
2625
- image: <<parameters.docker-image>>
27-
- image: amazon/dynamodb-local
28-
- image: consul
29-
- image: redis
3026

3127
steps:
3228
- checkout
@@ -46,24 +42,3 @@ jobs:
4642
path: ~/phpunit
4743
- store_artifacts:
4844
path: ~/phpunit
49-
50-
integration-test:
51-
docker:
52-
- image: circleci/php:7.3-cli-stretch
53-
- image: redis
54-
steps:
55-
- checkout
56-
- run:
57-
name: setup apcu
58-
command: |
59-
pecl config-set php_ini /usr/local/etc/php/php.ini
60-
yes '' | sudo pecl install -f apcu-4.0.10 || true;
61-
echo "extension=apcu.so" | sudo tee -a /usr/local/etc/php/conf.d/apcu.ini;
62-
echo "apc.enable_cli = 1" | sudo tee -a /usr/local/etc/php/conf.d/apcu.ini
63-
- run: composer update --no-progress
64-
- run: mkdir -p ~/phpunit
65-
- run: vendor/bin/phpunit integration-tests/CachedRedisFeatureRequesterTest.php
66-
- store_test_results:
67-
path: ~/phpunit
68-
- store_artifacts:
69-
path: ~/phpunit

CONTRIBUTING.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,4 @@ To run all unit tests:
3232
./vendor/bin/phpunit
3333
```
3434

35-
By default, the full unit test suite includes live tests of the integrations for Consul, DynamoDB, and Redis. Those tests expect you to have instances of all of those databases running locally. To skip them, set the environment variable `LD_SKIP_DATABASE_TESTS=1` before running the tests.
36-
3735
It is preferable to run tests against all supported minor versions of PHP (as described in `README.md` under Requirements), or at least the lowest and highest versions, prior to submitting a pull request. However, LaunchDarkly's CI tests will run automatically against all supported versions.

composer.json

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,15 @@
1919
"psr/log": "^1.0"
2020
},
2121
"require-dev": {
22-
"aws/aws-sdk-php": "^3.86",
2322
"friendsofphp/php-cs-fixer": ">=2.2.19 <3.0",
2423
"guzzlehttp/guzzle": "^7",
2524
"kevinrob/guzzle-cache-middleware": "^3",
2625
"phpunit/phpunit": "^9",
27-
"predis/predis": "^1.0",
28-
"sensiolabs/consul-php-sdk": "^4",
2926
"phpunit/php-code-coverage": "^9"
3027
},
3128
"suggest": {
3229
"guzzlehttp/guzzle": "(^7) Required when using GuzzleEventPublisher or the default FeatureRequester",
33-
"kevinrob/guzzle-cache-middleware": "(^3) Recommended for performance when using the default FeatureRequester",
34-
"predis/predis": "(^1.0) Required when using LDDFeatureRequester",
35-
"aws/aws-sdk-php": "(^3.86) Required when using DynamoDbFeatureRequester",
36-
"sensiolabs/consul-php-sdk": "(>=2.1 <3.0) Required when using ConsulFeatureRequester"
30+
"kevinrob/guzzle-cache-middleware": "(^3) Recommended for performance when using the default FeatureRequester"
3731
},
3832
"autoload": {
3933
"psr-4": {

integration-tests/CachedRedisFeatureRequesterTest.php

Lines changed: 0 additions & 262 deletions
This file was deleted.

integration-tests/README.txt

Lines changed: 0 additions & 7 deletions
This file was deleted.

integration-tests/Vagrantfile

Lines changed: 0 additions & 52 deletions
This file was deleted.

0 commit comments

Comments
 (0)