This repository was archived by the owner on Dec 6, 2024. It is now read-only.
Fix: return NULL if the provided user key in test data is NULL #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
reviewed
Aug 28, 2023
Contributor
|
Thanks for the bugfix! Please see the code review comment; otherwise this looks good. It will go out in our next release. |
Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
Contributor
|
Fixed in 2.9.2. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
None
Describe the solution you've provided
LDi_buildUsersJSON stops execution and returns when LDi_buildUsersJSON fails, which can happen because of lack of memory or if the provided userKey was NULL
Describe alternatives you've considered
None
Additional context
Since this code is used only for testing, it does not provide any high risk apart from a crash/undefined behaviour during testing.