refactor: remove onOverrideChange callback

Author: tarqd

app.js

@@ -165,20 +165,6 @@ async function initializeLaunchDarkly(clientSideID) {
 
     const eventInterceptionPlugin = new EventInterceptionPlugin();
 
-    // Store reference to client for display updates
-    let ldClient = null;
-
-    // Register callback for display updates when overrides change
-    flagOverridePlugin.onOverrideChange((flagKey, action) => {
-        if (!ldClient) return;
-
-        if (action === 'clear') {
-            displayFlags(ldClient, flagOverridePlugin);
-        } else if (flagKey) {
-            updateFlagDisplay(ldClient, flagKey, flagOverridePlugin);
-        }
-    });
-
     const context = {
         kind: 'user',
         key: 'example-user-' + Math.random().toString(36).substring(7),
@@ -196,9 +182,6 @@ async function initializeLaunchDarkly(clientSideID) {
         // Wait for initialization
         await client.waitForInitialization();
 
-        // Store client reference for use in monkey patches
-        ldClient = client;
-
         logger.info('LaunchDarkly client initialized successfully');
 
         // Display all flags initially

flag-url-override-plugin.js

@@ -19,10 +19,6 @@ export function createFlagUrlOverridePlugin(options = {}) {
     // Create the underlying plugin
     const plugin = new FlagOverridePlugin(overrideOptions);
 
-    // Store reference to client for display updates
-    let ldClient = null;
-    let updateDisplayCallback = null;
-
     /**
      * Load overrides from URL query parameters
      */
@@ -98,37 +94,25 @@ export function createFlagUrlOverridePlugin(options = {}) {
         }
     }
 
-    // Monkey patch setOverride to sync to URL and update display
+    // Monkey patch setOverride to sync to URL
     const originalSetOverride = plugin.setOverride.bind(plugin);
     plugin.setOverride = function(flagKey, value) {
         originalSetOverride(flagKey, value);
         syncOverridesToUrl(this.getAllOverrides());
-        // Notify callback if registered
-        if (updateDisplayCallback) {
-            updateDisplayCallback(flagKey, 'set');
-        }
     };
 
-    // Monkey patch removeOverride to sync to URL and update display
+    // Monkey patch removeOverride to sync to URL
     const originalRemoveOverride = plugin.removeOverride.bind(plugin);
     plugin.removeOverride = function(flagKey) {
         originalRemoveOverride(flagKey);
         syncOverridesToUrl(this.getAllOverrides());
-        // Notify callback if registered
-        if (updateDisplayCallback) {
-            updateDisplayCallback(flagKey, 'remove');
-        }
     };
 
-    // Monkey patch clearAllOverrides to sync to URL and refresh all flags
+    // Monkey patch clearAllOverrides to sync to URL
     const originalClearAllOverrides = plugin.clearAllOverrides.bind(plugin);
     plugin.clearAllOverrides = function() {
         originalClearAllOverrides();
         syncOverridesToUrl(this.getAllOverrides());
-        // Notify callback if registered
-        if (updateDisplayCallback) {
-            updateDisplayCallback(null, 'clear');
-        }
     };
 
     // Monkey patch registerDebug to load URL overrides
@@ -149,11 +133,6 @@ export function createFlagUrlOverridePlugin(options = {}) {
         }
     };
 
-    // Add helper method to register display update callback
-    plugin.onOverrideChange = function(callback) {
-        updateDisplayCallback = callback;
-    };
-
     // Add helper method to sync initial overrides to URL
     plugin.syncInitialOverrides = function() {
         const initialOverrides = this.getAllOverrides();