Skip to content

feat: add convenience function for adding multiple routes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2021
Merged

feat: add convenience function for adding multiple routes #9

merged 1 commit into from
Jun 24, 2021

Conversation

ian-rudge
Copy link
Contributor

@ian-rudge ian-rudge commented Jun 24, 2021 •
edited
Loading

this just adds a convenience function for adding multiple routes in a single function call.

rather than:

addRouteToRouter(...);
addRouteToRouter(...);
addRouteToRouter(...);

you can just do:

addRoutesToRouter(router, [
...
])

joelgallant
joelgallant approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@joelgallant joelgallant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Didn't realize you're back to LC 🙂

gregnr
gregnr approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@gregnr gregnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@ian-rudge ian-rudge merged commit be33539 into launchcodedev:master Jun 24, 2021
@ian-rudge ian-rudge deleted the add-multiple-routes branch June 24, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelgallant joelgallant joelgallant approved these changes

@gregnr gregnr gregnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-rudge @joelgallant @gregnr