Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag for overriding number of rows to fetch #944

Closed
wants to merge 2 commits into from

Conversation

imalsogreg
Copy link

@imalsogreg imalsogreg commented Dec 29, 2020

Addresses #933

I didn't want to add tests before seeing if the approach is something you'd be willing to merge. But if that's something you'd like, I could try to get a CockroachDB instance running in the test suite.

We did test this locally and it gets around the CockroachDB portals issue discussed in #933 (and in cockroachdb/cockroach#40195)

@mehcode
Copy link
Member

mehcode commented Dec 29, 2020

@imalsogreg do you think explicitly closing portals for fetch_one/optional instead would work?

@imalsogreg
Copy link
Author

@mehcode I believe so! But I wasn't able to figure out how to explicitly close a portal, or where to do that closing. Do you see how that would work?

@imalsogreg
Copy link
Author

Closing this because we're working on a better solution :)

@imalsogreg imalsogreg closed this Jan 7, 2021
@Cobular
Copy link

Cobular commented Sep 10, 2022

@imalsogreg I'm running into the issue described here: cockroachdb/cockroach#40195 when trying to use sqlx with cockroachdb right now and which this was supposed to fix - any update on said better solution? I am currently using sea_orm, which uses sqlx v0.6.1.

@abonander
Copy link
Collaborator

We have a fix on our end merged in #2081 which should release with 0.6.2, ideally this next week.

@Cobular
Copy link

Cobular commented Sep 11, 2022

Ah fantastic, thank you so much! I'll get on sea_orm about updating it's deps once that's out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants