Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Postgres decimals #889

Merged
merged 3 commits into from
Dec 19, 2020
Merged

Fix for Postgres decimals #889

merged 3 commits into from
Dec 19, 2020

Conversation

slumber
Copy link
Contributor

@slumber slumber commented Dec 10, 2020

See additional details #888
0.01 conversions could've been easily fixed without rewriting the whole thing, there's just one edge case that needs to be handled (see 2nd commit).
I couldn't find a standalone reproducer for the issue mentioned above, however, everything works fine with my branch.

@mehcode
Copy link
Member

mehcode commented Dec 17, 2020

Really appreciate you digging into this. This is a bit out of my direct understanding so pinging some people that know it better than I.


@pimeys and @abonander Can you take a look at this as you've looked at the decimals in here a bunch before?

@mehcode mehcode merged commit 405553c into launchbadge:master Dec 19, 2020
@mehcode
Copy link
Member

mehcode commented Dec 19, 2020

Thanks again ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants