Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MySQL] Fix minor issue in execute statement packet #739

Merged

Conversation

mcronce
Copy link
Contributor

@mcronce mcronce commented Oct 14, 2020

The MySQL protocol specifies that the iteration-count field should always be set to 1, but MySQL itself ignores the field entirely. Vitess is more strict and will reject execute packets with iteration-count set to anything other than 1.

It sounds like they may change to mimic actual MySQL behavior, but I figured you would like to also have the protocol correction on your end, even if it is borderline pedantic :)

…th(): Encode a 1 for iteration-count instead of 0
@abonander
Copy link
Collaborator

Thanks!

@mcronce
Copy link
Contributor Author

mcronce commented Oct 16, 2020

Thank you :) cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants