-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: no tx migration #3181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: no tx migration #3181
Conversation
767 no tx migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit.
could someone help me figure out why this test is failing? I can't reproduce the failure locally with Where Edit: it seems this test passed previous builds fine (failures were due to formatting), should we re-run? |
@abonander I have addressed your comment, please take a look when you have a chance |
@cleverjam @abonander is it expected that there seem to be no documentation update in this PR? |
I generally don't require PR authors to write documentation because I usually end up wanting to edit it heavily anyway. Migrations need a documentation pass in general, they're barely covered at all to begin with. When I get to it, I'll make sure to mention this feature. |
* test: add a failing test * feat: add no_tx to migration struct * feat: execute migration with no tx block * fix: expected string literal compilation error * test: update no tx to content comment * refactor: use the sql comment instead of file name semantics * docs: remove no_tx from file format comment * fix: remove filename matches * fix: messed up merge * refactor: dedupe migration * fix: move comment to where it makes sense * fix: linter error
Does your PR solve an issue?
Yes, this change allows for a way to create migrations that will be executed outside of the postgres transaction block.
It works as described in this comment
fixes #767
😬 accidentally closed #3159 when looking at merge conflicts