PostgreSQL Bugfix: Ensure connection is usable after failed COPY inside a transaction #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feikesteenbergen
force-pushed
the
fix_rollback_after_copy
branch
from
c6fc47f
to
c887853
Compare
feikesteenbergen
force-pushed
the
fix_rollback_after_copy
branch
from
c887853
to
96dedc1
Compare
While using COPY and subtransactions I kept running into errors.
This test case documents that error, it currently fails with:
Error: encountered unexpected or invalid data: expecting ParseComplete but received CommandComplete
When a COPY statement was in error inside a subtransaction, a Protocol Error used to be raised. By consuming the ReadyForQuery message when there is an error, we no longer have this issue.
feikesteenbergen
force-pushed
the
fix_rollback_after_copy
branch
from
96dedc1
to
70c1876
Compare
feikesteenbergen
changed the title
jayy-lmao
pushed a commit
to jayy-lmao/sqlx
that referenced
this pull request
Jun 6, 2024
…de a transaction (launchbadge#3138) * Include test case for regular subtransactions While using COPY and subtransactions I kept running into errors. This test case documents that error, it currently fails with: Error: encountered unexpected or invalid data: expecting ParseComplete but received CommandComplete * PostgreSQL Copy: Consume ReadyForQuery on error When a COPY statement was in error inside a subtransaction, a Protocol Error used to be raised. By consuming the ReadyForQuery message when there is an error, we no longer have this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using COPY and transactions I kept running into errors.
This PR includes a test case that triggers that error, it fails with:
The second commit contains the actual fix
Does your PR solve an issue?
fixesvalidates error of #3139