feat(logging): Log slow acquires from connection pool #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamjpotts are you planning on completing this draft PR? |
Yes. I wanted to beat it up a bit more first. |
iamjpotts
force-pushed
the
20240222-log-slow-acquires
branch
from
92f7410
to
ac42f63
Compare
abonander
requested changes
Mar 7, 2024
iamjpotts
force-pushed
the
20240222-log-slow-acquires
branch
2 times, most recently
from
cb6ceea
to
e3dd0b8
Compare
abonander
requested changes
Mar 12, 2024
iamjpotts
force-pushed
the
20240222-log-slow-acquires
branch
4 times, most recently
from
217cec7
to
49f3f45
Compare
Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
iamjpotts
force-pushed
the
20240222-log-slow-acquires
branch
from
49f3f45
to
0eac45d
Compare
jqphu
pushed a commit
to jqphu/sqlx
that referenced
this pull request
Apr 19, 2024
Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the connection pool is full, and all connections are in use, the next request for a connection involving
PoolInner::acquirewill block until a connection is released back to the pool.PoolOptionsThe default tries to avoid reporting a slow acquire when the pool grows itself within its capacity limit by creating a new connection.