postgres: remove IntervalStyle to fix #130 #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support more server versions, including CockroachDB, which only supports the `postgres` style.
|
No worries about the test failures. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way SQLx can support more server versions, including CockroachDB, which only supports the
postgresstyle.Of note: If we wanted to support conversion of PostgresSQL's
INTERVALs to a special type, we'd have to support all IntervalStyles anyway, in case somebody usedSET SESSION IntervalStyleto change it after connection is established.Fixes #130.
I believe the current
masterstruggles with Postgres tests a little so CI might fail.Thanks for the immediate response y'all!