Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlx db reset doesn't ask for confirmation #1146

Closed
jplatte opened this issue Apr 1, 2021 · 3 comments
Closed

sqlx db reset doesn't ask for confirmation #1146

jplatte opened this issue Apr 1, 2021 · 3 comments

Comments

@jplatte
Copy link
Contributor

jplatte commented Apr 1, 2021

Contrary to sqlx db drop, sqlx db reset doesn't ask for confirmation. They should both behave the same way.

@abonander
Copy link
Collaborator

There's an open PR already: #1128

I'm certainly inclined to merge except it would probably need to be a 0.{x + 1}.0 version bump since it's a breaking change to behavior.

@qqwa
Copy link
Contributor

qqwa commented Apr 2, 2021

I guess discussion is better in the issue. Regarding breaking changes I think it would be fine to wait for 0.{x + 1}.0 and would suggest that in the meantime we add a warning message to stdout or stderr, that the confirmation behavior will change in the next version.

For people who want to get asked for confirmation now, just have to use sqlx db reset -y. Maybe could be done with bash alias?

@mehcode
Copy link
Member

mehcode commented Apr 9, 2021

Fixed on master

@mehcode mehcode closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants