-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stash): clean up mutations, emit updates as a list #3376
Conversation
🦋 Changeset detectedLatest commit: e081b49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aa0cf04
to
9d190f8
Compare
34a8ee5
to
c670967
Compare
c670967
to
e1c6f2e
Compare
queueMicrotask(() => { | ||
notifySubscribers(stash); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my entrykit branch, I had removed queuing because it caused something in the live records sync to fail and fallback to the slower sync methods and was unclear why
queueMicrotask(() => { | |
notifySubscribers(stash); | |
}); | |
// TODO: wrap in queueMicrotask here once we figure out why it affects sync fallback | |
notifySubscribers(stash); |
do you know if this is an issue here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally with a fresh template and everything seems fine
making a mental note to come back to this if we see weird issues with syncing, esp large chunks of data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks for converting to an array of state changes 🙏
still unclear if queueMicrotask
is safe to do here and wondering if we tested this against a real app, or if we should remove for now
No description provided.