Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): update set-version to match new release structure, add --tag, --commit #1157

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Jul 13, 2023

  • updates the set-version cli command to work with the new release structure by adding two new options:
    • --tag: install the latest version of the given tag. For snapshot releases tags correspond to the branch name, commits to main result in an automatic snapshot release, so --tag main is equivalent to what used to be -v canary
    • --commit: install a version based on a given commit hash. Since commits from main result in an automatic snapshot release it works for all commits on main, and it works for manual snapshot releases from branches
  • set-version now updates all package.json nested below the current working directory (expect node_modules), so no need for running it each workspace of a monorepo separately.

@alvrs alvrs requested a review from holic as a code owner July 13, 2023 16:55
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023

🦋 Changeset detected

Latest commit: 73c3943

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@latticexyz/cli Major
@latticexyz/std-client Major
@latticexyz/dev-tools Major
@latticexyz/ecs-browser Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/react Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/store-sync Major
@latticexyz/store Major
@latticexyz/utils Major
@latticexyz/world Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@dk1a dk1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you wanna update templates, they still use set-version -v canary

have you seen https://yargs.js.org/docs/#api-reference-conflictsx-y ? not sure it fits this case though

@alvrs
Copy link
Member Author

alvrs commented Jul 13, 2023

I think you wanna update templates, they still use set-version -v canary

good catch, updated

have you seen https://yargs.js.org/docs/#api-reference-conflictsx-y ? not sure it fits this case though

We could use it, but would have to add an array of the other 4 elements to each of ["mudVersion", "link", "tag", "commit", "restore"]; so I think in this case the non-yargs solution is easier

@alvrs alvrs merged commit c36ffd1 into main Jul 13, 2023
8 of 9 checks passed
@alvrs alvrs deleted the alvrs/set-version branch July 13, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants