remove world functions

Author: frolic

packages/world-module-batchstore/mud.config.ts

@@ -6,4 +6,12 @@ export default defineWorld({
     // generate into experimental dir until these are stable/audited
     systemLibrariesDirectory: "experimental/systems",
   },
+  systems: {
+    BatchStoreSystem: {
+      deploy: {
+        disabled: true,
+        registerWorldFunctions: false,
+      },
+    },
+  },
 });

packages/world-module-batchstore/src/BatchStoreModule.sol

@@ -17,26 +17,8 @@ contract BatchStoreModule is Module {
   function installRoot(bytes memory encodedArgs) public override {
     ResourceId systemId = batchStoreSystem.toResourceId();
 
-    if (!ResourceIds.getExists(systemId)) {
-      worldRegistrationSystem.callAsRoot().registerSystem(systemId, systemAddress, true);
-      // TODO: since this is a scary/internal and use-with-caution module/system, should we not register function selectors?
-      worldRegistrationSystem.callAsRoot().registerRootFunctionSelector(
-        systemId,
-        "getTableRecords(bytes32,bytes32[][])",
-        "getTableRecords(bytes32,bytes32[][])"
-      );
-      worldRegistrationSystem.callAsRoot().registerRootFunctionSelector(
-        systemId,
-        "setTableRecords(bytes32,(bytes32[],bytes,bytes32,bytes)[])",
-        "setTableRecords(bytes32,(bytes32[],bytes,bytes32,bytes)[])"
-      );
-      worldRegistrationSystem.callAsRoot().registerRootFunctionSelector(
-        systemId,
-        "deleteTableRecords(bytes32,bytes32[][])",
-        "deleteTableRecords(bytes32,bytes32[][])"
-      );
-    } else if (batchStoreSystem.getAddress() != address(systemAddress)) {
-      // upgrade system
+    if (batchStoreSystem.getAddress() != address(systemAddress)) {
+      // install or upgrade system
       worldRegistrationSystem.callAsRoot().registerSystem(systemId, systemAddress, true);
     }
   }

packages/world-module-batchstore/src/codegen/world/IBatchStoreSystem.sol

@@ -40,10 +40,10 @@ contract BatchStoreModuleTest is Test, GasReporter {
     keys[0] = NamespaceOwner.encodeKeyTuple(WorldResourceIdLib.encodeNamespace(""));
 
     startGasReport("get table records");
-    world.getTableRecords(NamespaceOwner._tableId, keys);
+    batchStoreSystem.getTableRecords(NamespaceOwner._tableId, keys);
     endGasReport();
 
-    TableRecord[] memory records = world.getTableRecords(NamespaceOwner._tableId, keys);
+    TableRecord[] memory records = batchStoreSystem.getTableRecords(NamespaceOwner._tableId, keys);
     assertEq(records.length, 1);
     assertEq(records[0].keyTuple, keys[0]);
 
@@ -73,7 +73,7 @@ contract BatchStoreModuleTest is Test, GasReporter {
     });
 
     startGasReport("set table records");
-    world.setTableRecords(NamespaceOwner._tableId, records);
+    batchStoreSystem.setTableRecords(NamespaceOwner._tableId, records);
     endGasReport();
 
     assertEq(NamespaceOwner.get(namespace), address(this));
@@ -91,7 +91,7 @@ contract BatchStoreModuleTest is Test, GasReporter {
     keys[0] = NamespaceOwner.encodeKeyTuple(namespace);
 
     startGasReport("delete table records");
-    world.deleteTableRecords(NamespaceOwner._tableId, keys);
+    batchStoreSystem.deleteTableRecords(NamespaceOwner._tableId, keys);
     endGasReport();
 
     assertEq(NamespaceOwner.get(namespace), address(0));