Define all DBAPI required errors in prestodb.exceptions

Author: takuti

prestodb/dbapi.py

@@ -40,22 +40,6 @@
 logger = prestodb.logging.get_logger(__name__)
 
 
-class Error(Exception):
-    pass
-
-
-class OperationalError(Error):
-    """
-
-    Exception raised for errors that are related to the database's operation
-    and not necessarily under the control of the programmer, e.g. an unexpected
-    disconnect occurs, the data source name is not found, a transaction could
-    not be processed, a memory allocation error occurred during processing, ...
-
-    """
-    pass
-
-
 def connect(*args, **kwargs):
     """Constructor for creating a connection to the database.
 
@@ -266,7 +250,7 @@ def fetchone(self):
         except StopIteration:
             return None
         except prestodb.exceptions.HttpError as err:
-            raise OperationalError(str(err))
+            raise prestodb.exceptions.OperationalError(str(err))
 
     def fetchmany(self, size=None):
         # type: (Optional[int]) -> List[List[Any]]
@@ -311,7 +295,7 @@ def fetchall(self):
 
     def cancel(self):
         if self._query is None:
-            raise OperationalError("Cancel query failed; no running query")
+            raise prestodb.exceptions.OperationalError("Cancel query failed; no running query")
         self._query.cancel()
 
     def close(self):

prestodb/exceptions.py

@@ -40,10 +40,6 @@ class PrestoError(Exception):
     pass
 
 
-class DatabaseError(Exception):
-    pass
-
-
 class TimeoutError(Exception):
     pass
 
@@ -176,3 +172,44 @@ def __init__(
     def retry(self, func, args, kwargs, err, attempt):
         delay = self._get_delay(attempt)
         time.sleep(delay)
+
+
+# PEP 249
+class Error(Exception):
+    pass
+
+
+class Warning(Exception):
+    pass
+
+
+class InterfaceError(Error):
+    pass
+
+
+class DatabaseError(Error):
+    pass
+
+
+class InternalError(DatabaseError):
+    pass
+
+
+class OperationalError(DatabaseError):
+    pass
+
+
+class ProgrammingError(DatabaseError):
+    pass
+
+
+class IntegrityError(DatabaseError):
+    pass
+
+
+class DataError(DatabaseError):
+    pass
+
+
+class NotSupportedError(DatabaseError):
+    pass