feat:[lar-134] use theadId in action , remove array variable etc...

Author: cybersoldattech

app/Actions/Forum/CreateOrUpdateThreadAction.php

@@ -11,13 +11,12 @@
 
 final class CreateOrUpdateThreadAction
 {
-    public function execute(array $formValues, ?Thread $thread = null): Thread
+    public function execute(array $formValues, ?int $threadId = null): Thread
     {
-        return DB::transaction(function () use ($formValues, $thread) {
-            $edit = (bool) $thread?->id;
-            $thread = Thread::query()->updateOrCreate(['id' => $thread?->id], $formValues);
+        return DB::transaction(function () use ($formValues, $threadId) {
+            $thread = Thread::query()->updateOrCreate(['id' => $threadId], $formValues);
 
-            if (! $edit) {
+            if (! $threadId) {
                 app(SubscribeToThreadAction::class)->execute($thread);
 
                 givePoint(new ThreadCreated($thread));

app/Livewire/Components/Slideovers/ThreadForm.php

@@ -122,7 +122,7 @@ public function save(): void
 
         $thread = app(CreateOrUpdateThreadAction::class)->execute(
             formValues: $validated,
-            thread: $this->thread
+            threadId: $this->thread?->id
         );
 
         $this->form->model($thread)->saveRelationships();
@@ -136,7 +136,7 @@ public function save(): void
             ->success()
             ->send();
 
-        $this->redirect(route('forum.show', ['thread' => $thread ?? $this->thread]), navigate: true); // @phpstan-ignore-line
+        $this->redirect(route('forum.show', ['thread' => $thread]), navigate: true);
     }
 
     public function render(): View

tests/Feature/Actions/Forum/CreateOrUpdateThreadActionTest.php

@@ -13,22 +13,21 @@
 
 beforeEach(function (): void {
     $this->user = $this->login();
+
     Event::fake();
     Notification::fake();
 });
 
 it('user can create a thread', function (): void {
-    $channelOne = Channel::factory()->create(['name' => 'channel 1', 'slug' => 'channel-1']);
-    $channelTwo = Channel::factory()->create(['name' => 'channel 2', 'slug' => 'channel-2']);
-    $threadData = [
+    $channels = Channel::factory()->count(2)->create();
+
+    $thread = app(createOrUpdateThreadAction::class)->execute([
         'title' => 'thread title',
         'slug' => 'thread-title',
         'user_id' => $this->user->id,
         'body' => 'This is a test action thread for created or updated thread.',
-        'channels' => [$channelOne->id, $channelTwo->id],
-    ];
-
-    $thread = app(createOrUpdateThreadAction::class)->execute($threadData);
+        'channels' => [$channels->first(), $channels->last()],
+    ]);
 
     expect($thread)
         ->toBeInstanceOf(Thread::class)
@@ -44,11 +43,9 @@
 
     $thread->channels()->attach($channels->modelKeys());
 
-    $threadData = [
+    $thread = app(createOrUpdateThreadAction::class)->execute([
         'title' => 'update thread title',
-    ];
-
-    $thread = app(createOrUpdateThreadAction::class)->execute($threadData, $thread);
+    ], $thread->id);
 
     expect($thread)
         ->toBeInstanceOf(Thread::class)