Skip to content

Add support for optional custom fixers and rules in pint.json #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Add support for optional custom fixers and rules in pint.json #239

wants to merge 7 commits into from

Conversation

mho22
Copy link

@mho22 mho22 commented Dec 24, 2023

Based on PR suggestion : #26

It allows to add some external rules into your current projet, if needed :

{
    "fixers": [
        "External\\Custom\\Fixer"
    ],
    "rules": {
        "External/Custom/Fixer/rule": {
            "foo": true
        }
    }
}

This doesn't break the actual use of Laravel Pint, it opens the possibility to use the custom fixers from Pint outside of it.

P.S.: Some test files have been reorganized due to the actual use of fixers directory.

@mho22
Copy link
Author

mho22 commented Dec 24, 2023

Apologies for the multiple unnecessary commits. I encountered difficulties meeting the checks.

By the way, Merry Christmas! 🎄

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@mho22 mho22 deleted the custom-rules-patch branch June 3, 2024 11:02
@Riley19280 Riley19280 mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants