[1.x] Makes Pint 40x faster (#376)

* Adds `--parallel`

* Bumps dependencies

* sends build

* Puts in place overrides

* Uses `setUnsupportedPhpVersionAllowed`

* fix

* Fixes types

* adds `(Experimental)`

* Fixes CI

* note

* chore: ignores overrides on export

* buillds

* fix

Author: nunomaduro

.github/workflows/tests.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        os: [ubuntu-22.04, windows-2019]
+        os: [ubuntu-22.04, windows-2022]
         php: [8.2, 8.3, 8.4]
 
     name: PHP ${{ matrix.php }} - ${{ matrix.os }}
@@ -52,6 +52,9 @@ jobs:
       - name: Execute lint tests with Laravel preset
         run: ./pint --test
 
+      - name: Execute lint tests in parallel with Laravel preset
+        run: ./pint --parallel --test
+
       - name: Execute static analysis
         run: vendor/bin/phpstan
         if: matrix.php == '8.4'

app/Actions/FixCode.php

@@ -4,7 +4,10 @@
 
 use App\Factories\ConfigurationResolverFactory;
 use LaravelZero\Framework\Exceptions\ConsoleException;
+use PhpCsFixer\Console\ConfigurationResolver;
 use PhpCsFixer\Runner\Runner;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
 
 class FixCode
 {
@@ -45,8 +48,10 @@ public function execute()
             $this->progress->subscribe();
         }
 
+        $method = $this->input->getOption('parallel') ? 'fixParallel' : 'fixSequential';
+
         /** @var array<string, array{appliedFixers: array<int, string>, diff: string}> $changes */
-        $changes = (new Runner(
+        $changes = (fn () => $this->{$method}())->call(new Runner(
             $resolver->getFinder(),
             $resolver->getFixers(),
             $resolver->getDiffer(),
@@ -56,9 +61,34 @@ public function execute()
             $resolver->isDryRun(),
             $resolver->getCacheManager(),
             $resolver->getDirectory(),
-            $resolver->shouldStopOnViolation()
-        ))->fix();
+            $resolver->shouldStopOnViolation(),
+            $resolver->getParallelConfig(),
+            $this->getInput($resolver),
+        ));
 
         return tap([$totalFiles, $changes], fn () => $this->progress->unsubscribe());
     }
+
+    /**
+     * Gets the input for the PHP CS Fixer Runner.
+     */
+    private function getInput(ConfigurationResolver $resolver): InputInterface
+    {
+        // @phpstan-ignore-next-line
+        $definition = (fn () => $this->definition)->call($this->input);
+
+        $definition->addOptions([
+            new InputOption('stop-on-violation', null, InputOption::VALUE_REQUIRED, ''),
+            new InputOption('allow-risky', null, InputOption::VALUE_REQUIRED, ''),
+            new InputOption('rules', null, InputOption::VALUE_REQUIRED, ''),
+            new InputOption('using-cache', null, InputOption::VALUE_REQUIRED, ''),
+        ]);
+
+        $this->input->setOption('stop-on-violation', $resolver->shouldStopOnViolation());
+        $this->input->setOption('allow-risky', $resolver->getRiskyAllowed() ? 'yes' : 'no');
+        $this->input->setOption('rules', json_encode($resolver->getRules()));
+        $this->input->setOption('using-cache', $resolver->getUsingCache() ? 'yes' : 'no');
+
+        return $this->input;
+    }
 }

app/Commands/DefaultCommand.php

@@ -47,7 +47,8 @@ protected function configure()
                     new InputOption('output-to-file', '', InputOption::VALUE_REQUIRED, 'Output the test results to a file at this path'),
                     new InputOption('output-format', '', InputOption::VALUE_REQUIRED, 'The format that should be used when outputting the test results to a file'),
                     new InputOption('cache-file', '', InputArgument::OPTIONAL, 'The path to the cache file'),
-                ]
+                    new InputOption('parallel', '', InputOption::VALUE_NONE, 'Runs the linter in parallel (Experimental)'),
+                ],
             );
     }
 

app/Factories/ConfigurationFactory.php

@@ -42,12 +42,13 @@ class ConfigurationFactory
      */
     public static function preset($rules)
     {
-        return (new Config)
+        return (new Config) // @phpstan-ignore-line
             ->setParallelConfig(ParallelConfigFactory::detect())
             ->setFinder(self::finder())
             ->setRules(array_merge($rules, resolve(ConfigurationJsonRepository::class)->rules()))
             ->setRiskyAllowed(true)
-            ->setUsingCache(true);
+            ->setUsingCache(true)
+            ->setUnsupportedPhpVersionAllowed(true);
     }
 
     /**

box.json

@@ -4,6 +4,7 @@
         "app",
         "bootstrap",
         "config",
+        "overrides",
         "resources",
         "vendor"
     ],

builds/pint

@@ -23,10 +23,10 @@
         "ext-xml": "*"
     },
     "require-dev": {
-        "friendsofphp/php-cs-fixer": "^3.75.0",
-        "illuminate/view": "^11.44.7",
-        "larastan/larastan": "^3.4.0",
-        "laravel-zero/framework": "^11.36.1",
+        "friendsofphp/php-cs-fixer": "^3.76.0",
+        "illuminate/view": "^11.45.1",
+        "larastan/larastan": "^3.5.0",
+        "laravel-zero/framework": "^11.45.0",
         "mockery/mockery": "^1.6.12",
         "nunomaduro/termwind": "^2.3.1",
         "pestphp/pest": "^2.36.0"
@@ -36,7 +36,10 @@
             "App\\": "app/",
             "Database\\Factories\\": "database/factories/",
             "Database\\Seeders\\": "database/seeders/"
-        }
+        },
+        "files": [
+            "overrides/Runner/Parallel/ProcessFactory.php"
+        ]
     },
     "autoload-dev": {
         "psr-4": {