Skip to content

[13.x] Document changes to oauth_clients table in upgrade guide #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gdebrauwer
Copy link
Contributor

No description provided.

@hafezdivandari
Copy link
Contributor

hafezdivandari commented Jun 3, 2025

As you know, these changes are backward compatible, so no upgarde guide entry is needed, as it may cause more confusion than clearifying things IMO. Also it doesn't explain the steps required to apply the changes. The upgarde guide doesn't meant to explain same things as the changelog?

@gdebrauwer
Copy link
Contributor Author

@hafezdivandari I initially did not change that table in my projects, but then my OAuth tests failed. These failures were caused by calling Client::factory()->create(). That factory assumes the table uses the new columns.

@hafezdivandari
Copy link
Contributor

@gdebrauwer You are right, so we can instruct the user to use the old ClientFactory, something like the following:

Passport's Laravel\Passport\Database\Factories\ClientFactory factory class has been changed based on the new schema, you may use the old factory class...

@taylorotwell taylorotwell marked this pull request as draft June 4, 2025 13:46
@gdebrauwer gdebrauwer marked this pull request as ready for review June 5, 2025 08:01
@taylorotwell taylorotwell merged commit cc80677 into laravel:13.x Jun 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants