Skip to content

[13.x] Cleanup #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2024
Merged

[13.x] Cleanup #1758

merged 3 commits into from
Jun 24, 2024

Conversation

hafezdivandari
Copy link
Contributor

Cleanup.

  • Do not create password grant client (deprecated grant) on install command anymore.
  • Remove unused \Laravel\Passport\TokenRepository from \Laravel\Passport\Guards\TokenGuard and \Laravel\Passport\Http\Middleware\CheckCredentials classes.
  • Remove \Laravel\Passport\RefreshToken::transient() method, probably copy/pasted from Token model class mistakenly long time ago!
  • Fix doc types on \Laravel\Passport\Guards\TokenGuard class.
  • Deprecate some unused methods to be removed later:
    • \Laravel\Passport\AuthCode::client() method
    • \Laravel\Passport\Client::authCodes() method
    • \Laravel\Passport\TokenRepository::getValidToken() method
  • Use $defaultScope on PersonalAccessGrant.

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@driesvints
Copy link
Member

Is there an upgrade path for this? I suspect not but can't hurt to check I thought.

@hafezdivandari
Copy link
Contributor Author

hafezdivandari commented Jun 24, 2024

@driesvints No, I always update upgrade guide if needed, this one is just cleanup.

@hafezdivandari hafezdivandari marked this pull request as ready for review June 24, 2024 20:43
@taylorotwell taylorotwell merged commit 1cf9234 into laravel:13.x Jun 24, 2024
9 checks passed
@hafezdivandari hafezdivandari deleted the 13.x-cleanup branch June 24, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants