add optional clientId param to createToken #1517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Breaking change I don't want to make - set the personal_access_client in the configuration. |
|
@taylorotwell Correct. But what if there is multiple personal access clients? How we can switch dynamically between them? |
|
What if we add a new method to create tokens for a specific client? |
|
me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, The
createTokenmethod uses the first personal access client from the database if thepassport.personal_access_clientconfig wasn't set at all.I added the
clientIdparam to thecreateTokenmethod so you can create tokens for any clients by their id.