Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

^3.0 compatibility with dependency broken #992

Closed
soundsgoodsofar opened this issue Mar 19, 2019 · 1 comment
Closed

^3.0 compatibility with dependency broken #992

soundsgoodsofar opened this issue Mar 19, 2019 · 1 comment

Comments

@soundsgoodsofar
Copy link

In zendframework/zend-diactoros 1.8.6, they made a breaking change in src/MessageTrait.php

zendframework/zend-diactoros@ee4bcdc#diff-5abca4d9d5693da46d10a54795b1192d

This change means that the following line in ServerBag.php results in an exception being thrown for an empty header.

$headers['PHP_AUTH_PW'] = isset($this->parameters['PHP_AUTH_PW']) ? $this->parameters['PHP_AUTH_PW'] : '';

Propose to change that line to:

if (isset($this->parameters['PHP_AUTH_PW'])) {
    $headers['PHP_AUTH_PW'] = $this->parameters['PHP_AUTH_PW'];
}
@driesvints driesvints added bug and removed bug labels Mar 21, 2019
@driesvints
Copy link
Member

This line seems to be in place in Symfony's HttpFoundation's ServerBag class. So it would have to be fixed there instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants