TokenGuard query token twice

[halaei]

The following sql statement is queried twice during a call to TokenGuard::authenticateViaBearerToken() function:

select * from `oauth_access_tokens` where `oauth_access_tokens`.`id` = ? limit 1

[rdgout]

I also see this happening on my API using Laravel Passport (v2.0.11)

[gbdematos]

Finally found someone with the same "problem", it's driving me nuts to figure out why this is happening.

I have a simple app to test it, installed passport and made vue make a request to some route with an authorization header. The following queries are executed, in this order:

select * from `oauth_access_tokens` where `oauth_access_tokens`.`id` = '[...]' limit 1
select * from `users` where `id` = '1' and `users`.`deleted_at` is null limit 1
select * from `oauth_access_tokens` where `oauth_access_tokens`.`id` = '[...]' limit 1
select * from `oauth_clients` where `oauth_clients`.`id` = '2' limit 1

(removed the token for presentation purposes)

[sylouuu]

Same issue here.

[Kolimar]

still happening

[hudovisk]

I am having the same issue here,
the first query is coming from a check to see if the token is revoked:

passport/src/Guards/TokenGuard.php

Line 109 in 9dbcc3d

$psr = $this->server->validateAuthenticatedRequest($psr);

Then the oauth_access_tokens is queried again right after:

passport/src/Guards/TokenGuard.php

Line 125 in 9dbcc3d

$token = $this->tokens->find(

[raphaelbadia]

Same issue here, the fun part is that it's happening in the same try block

[fannyfan414]

Same issue, always 2 duplicated request to database

[CrashXD]

Same issue

[pnlinh-it]

Same issue!

[calvinmuller]

Same issue here

[driesvints]

Since this is an optimization rather than something blocking, feel free to send in a PR to solve this problem.

[tylik1]

@driesvints this is not optimization, it certainly looks like a bug. For me Auth::user(); calls the query twice, on every single Ajax request i make.
Can you please reopen, even if it won't be solved now?

select * from "oauth_access_tokens" where "id" = token_id' limit 1

Backtrace:

First request:

15. /vendor/laravel/passport/src/TokenRepository.php:32
16. /vendor/laravel/passport/src/TokenRepository.php:108
17. /vendor/laravel/passport/src/Bridge/AccessTokenRepository.php:87
18. /vendor/league/oauth2-server/src/AuthorizationValidators/BearerTokenValidator.php:85
19. /vendor/league/oauth2-server/src/ResourceServer.php:84
20. /vendor/laravel/passport/src/Guards/TokenGuard.php:109
21. /vendor/laravel/passport/src/Guards/TokenGuard.php:89
22. /vendor/laravel/passport/src/PassportServiceProvider.php:272
25. /vendor/laravel/framework/src/Illuminate/Auth/AuthManager.php:292

Second request:

15. /vendor/laravel/passport/src/TokenRepository.php:32
16. /vendor/laravel/passport/src/Guards/TokenGuard.php:126
17. /vendor/laravel/passport/src/Guards/TokenGuard.php:89
18. /vendor/laravel/passport/src/PassportServiceProvider.php:272
21. /vendor/laravel/framework/src/Illuminate/Auth/AuthManager.php:292
22. /vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:223

[driesvints]

@tylik1 this isn't exactly blocking or causing issues. If you can optimize the process in a clean way which reduces the queries to one feel free to send in a PR.