fix: add return type

[alipowerful7]

last() method return TValue but in join method just write string

before:

/**
     * Join all items from the collection using a string. The final items can use a separate glue string.
     *
     * @param  string  $glue
     * @param  string  $finalGlue
     * @return string
     */
    public function join($glue, $finalGlue = '')
    {
        if ($finalGlue === '') {
            return $this->implode($glue);
        }

        $count = $this->count();

        if ($count === 0) {
            return '';
        }

        if ($count === 1) {
            return $this->last();
        }

        $collection = new static($this->items);

        $finalItem = $collection->pop();

        return $collection->implode($glue).$finalGlue.$finalItem;
    }

after:

/**
     * Join all items from the collection using a string. The final items can use a separate glue string.
     *
     * @param  string  $glue
     * @param  string  $finalGlue
     * @return TValue|string
     */
    public function join($glue, $finalGlue = '')
    {
        if ($finalGlue === '') {
            return $this->implode($glue);
        }

        $count = $this->count();

        if ($count === 0) {
            return '';
        }

        if ($count === 1) {
            return $this->last();
        }

        $collection = new static($this->items);

        $finalItem = $collection->pop();

        return $collection->implode($glue).$finalGlue.$finalItem;
    }

[shaedrich]

Where did you get that from? value() is used on $default to make sure to call the $default in case it's a callable:

framework/src/Illuminate/Collections/Arr.php

Line 272 in 9190754

return $key !== null ? $array[$key] : value($default);

[rodrigopedra]

last() method return \Closure()

No, it doesn't. It returns whatever the collection holds (TValue), or whatever is passed as default, or if the default is a closure, whatever that closure returns (TLastDefault)

framework/src/Illuminate/Collections/Collection.php

Lines 778 to 790 in 9190754

	/**
	* Get the last item from the collection.
	*
	* @template TLastDefault
	*
	* @param (callable(TValue, TKey): bool)|null $callback
	* @param TLastDefault|(\Closure(): TLastDefault) $default
	* @return TValue|TLastDefault
	*/
	public function last(?callable $callback = null, $default = null)
	{
	return Arr::last($this->items, $callback, $default);
	}

And TValue is defined class wise here:

framework/src/Illuminate/Collections/Collection.php

Lines 15 to 23 in 9190754

	/**
	* @template TKey of array-key
	*
	* @template-covariant TValue
	*
	* @implements \ArrayAccess<TKey, TValue>
	* @implements \Illuminate\Support\Enumerable<TKey, TValue>
	*/
	class Collection implements ArrayAccess, CanBeEscapedWhenCastToString, Enumerable

[rodrigopedra]

I'd say you could change it to:

/**
 * Join all items from the collection using a string. The final items can use a separate glue string.
 *
 * @param  string  $glue
 * @param  string  $finalGlue
 * @return TValue|string
 */
public function join($glue, $finalGlue = '')

Or maybe add a cast to string when $count === 1, to ensure Collection@join always return a string:

if ($count === 1) {
    return strval($this->last());
}

[alipowerful7]

@rodrigopedra thank you.
i changed to this

@return TValue|string