Skip to content

[12.x] Pass LoggerInterface when constructing RoundrobinTransport instance #56244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 12.x
Choose a base branch
from

Conversation

jnoordsij
Copy link
Contributor

As a follow-up to symfony/symfony#60110 which introduces an additional constructor property logger to the RoundRobinTransport class, this PR ensures the app-bound LoggerInterface will be passed when constructing such a class.

Note that this will require Symfony 7.4.0 or higher, which is due for release in November 2025. Given that passing additional parameters to constructors is allowed in PHP (they are just silently ignored), this PR as such is both backwards and forwards compatible, however at current would do effectively nothing. If therefore it is preferable to keep this as draft until (near) the release of Symfony 7.4, that is also perfectly fine with me.

I've already tested to ensure tests still pass with the following composer.json patch:

         "symfony/finder": "^7.2.0",
         "symfony/http-foundation": "^7.2.0",
         "symfony/http-kernel": "^7.2.0",
-        "symfony/mailer": "^7.2.0",
+        "symfony/mailer": "7.4.x-dev as 7.4.0",
         "symfony/mime": "^7.2.0",
         "symfony/polyfill-php83": "^1.31",
         "symfony/process": "^7.2.0",

@jnoordsij jnoordsij marked this pull request as draft July 8, 2025 17:44
@jnoordsij
Copy link
Contributor Author

As static analysis (logically) fails I'll go ahead and keep this in draft until November.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant