Skip to content

[12.x] Fix ResponseFactory should also accept null callback #55833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

[12.x] Fix ResponseFactory should also accept null callback #55833

merged 1 commit into from
May 23, 2025

Conversation

crynobone
Copy link
Member

Symfony\Component\HttpFoundation\StreamedResponse supports callable|null but we currently expect $callback to just be Closure.

Fixes #55831

@crynobone
[12.x] Fix ResponseFactory should also accept null callback
9e44444 
`Symfony\Component\HttpFoundation\StreamedResponse` supports
`callable|null` but we currently expect `$callback` to just be
`Closure`.

Fixes #55831

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review May 23, 2025 02:38
@taylorotwell taylorotwell merged commit 623886a into 12.x May 23, 2025
62 checks passed
@taylorotwell taylorotwell deleted the 12/issue-55831 branch May 23, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

response()->stream() params inconsistent with Symfony, breaks Livewire
2 participants
@crynobone @taylorotwell