Skip to content

[12.x] Fix TestResponse::assertSessionMissing() when given an array of keys #55800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025

Conversation

crynobone
Copy link
Member

PR #55763 removes else from the is_array($key) condition, which causes a regression bug in the existing applications.

CleanShot 2025-05-21 at 11 50 14

… of keys

PR #55763 remove `else` from `is_array($key)` condition which cause
regression bug to occur on existing application.

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review May 21, 2025 03:51
crynobone added 2 commits May 21, 2025 13:18
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Co-authored-by: Sebastian Hädrich <11225821+shaedrich@users.noreply.github.com>
@taylorotwell taylorotwell merged commit 7de96ad into 12.x May 21, 2025
60 checks passed
@taylorotwell taylorotwell deleted the 12/regression-55763 branch May 21, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants