[12.x] Update assertSessionMissing() signature to match assertSessionHas()
#55763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexxai
changed the title
assertSessionMissing() to allow checking for specific valueassertSessionMissing() signature to match assertSessionHas()
|
PSA: While this is not a breaking change, if you were accidentally passing a second argument to |
crynobone
added a commit
that referenced
this pull request
May 21, 2025
… of keys PR #55763 remove `else` from `is_array($key)` condition which cause regression bug to occur on existing application. Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
taylorotwell
pushed a commit
that referenced
this pull request
May 21, 2025
… of keys (#55800) * [12.x] Fix `TestResponse::assertSessionMissing()` when given an array of keys PR #55763 remove `else` from `is_array($key)` condition which cause regression bug to occur on existing application. Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Update tests/Testing/TestResponseTest.php Co-authored-by: Sebastian Hädrich <11225821+shaedrich@users.noreply.github.com> --------- Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> Co-authored-by: Sebastian Hädrich <11225821+shaedrich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Until now, it has been impossible to check the session to confirm that a specific value is not set.
For example: let's say I have a session key called
guest_idwhich contains a value that must rotate to a new randomly generated string on every page view. Prior to this patch, there was no easy way to validate that the value had actually changed. You could assert that the key was the same or that the value was missing, but you could not check that it had rotated to some new unknown value.NOTE: This is not a breaking change
Proposed solution
I mostly replicated the logic from
assertSessionHas()above to allow a user to provide a specific value that must not be set in a specific key. Also likeassertSessionHas(), it preserves the original logic where if no value is provided, it just checks that the key is missing altogether.