[12.x] Fix handling of default values for route parameters with a binding field #55697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eld, where a default is not present for that same parameter without a binding field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a case where you set a default value for a route parameter with a binding field (
tenant:slug) but not for that same parameter without a binding field (tenant).I overlooked this in my original PR, essentially a false positive due to the structure of the tests (all defaults were always set). Now I temporarily remove the default value while repeating some assertions. Can confirm the tests fail without the fix. And the fix just makes sure to check the right default (with the binding field in mind).