Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
inspired from today' s stream by @jasonmccreary (about atomic locks and the struggle to test the exception)
i've added a missing test which also can be used as an example on how to test lock/block for other users.
Cache::lock('foo')->forceRelease();
as first line => moved tosetUp
sleep(2)
to test the lock is release afterwards => usedSleep
facade which is use inCache
block
runs into a timeoutlet me know if i should split this up into more PRs.
cheers
adrian