Skip to content

[11.x] Bump minimum league/commonmark #55660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrextor
Copy link
Contributor

This PR bumps the minimum required version of league/commonmark to ^2.7 in order to patch a moderate-severity XSS vulnerability in the Attributes extension.

The vulnerability affects versions <2.7.0 and allows malicious HTML attributes to be injected into rendered Markdown—even when secure configuration options like html_input: 'strip' and allow_unsafe_links: false are used. A specially crafted payload such as:

@arttiger
Copy link

arttiger commented May 6, 2025

This pull request duplicates [#55659]

@andrextor
Copy link
Contributor Author

This pull request duplicates [#55659]

This PR specifically targets the 11.x branch to ensure the XSS patch is applied to Laravel 11.
The linked PR (#55659) appears to address 12.x, but doesn’t cover the current LTS version.

@andrextor andrextor changed the title Bump minimum league/commonmark [11.x] Bump minimum league/commonmark May 6, 2025
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be applied to both src/Illuminate/Mail/composer.json and src/Illuminate/Support/composer.json too.

@andrextor andrextor requested a review from GrahamCampbell May 6, 2025 18:14
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing in Support.

@andrextor andrextor force-pushed the 11.x-Bump-minimum-league-commonmark branch from a5982e6 to 795b01f Compare May 6, 2025 18:15
@andrextor andrextor requested a review from GrahamCampbell May 6, 2025 18:17
@andrextor
Copy link
Contributor Author

Still missing in Support.

@taylorotwell taylorotwell merged commit abb1119 into laravel:11.x May 6, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants