Skip to content

[12.x] Fix for global autoload relationships not working in certain cases #55443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

litvinchuk
Copy link
Contributor

Fix for #55438 issue

In the current implementation of #53655, Model::automaticallyEagerLoadRelationships does not work in certain cases.

For example:

Model::automaticallyEagerLoadRelationships();

class Project extends Model
{
    public function contracts()
    {
        return $this->belongsToMany(Contract::class);
    }
}

# Autoloading works fine here
foreach ($project->contracts as $contract) {
    $contractors[] = $contract->contractor;
}

# Not working — we have an N+1 issue here
foreach ($project->contracts()->get() as $contract) {
    $contractors[] = $contract->contractor;
}

After this fix, both scenarios work as expected.

@taylorotwell taylorotwell merged commit 5548f95 into laravel:12.x Apr 18, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model::automaticallyEagerLoadRelationships doesn't work for BelongsToMany
2 participants